PR State:
merged
PR:
#10214
Commit:
e29074b4b564ff7add664f6939b4972f34ed4879
[FIX] to_base : fix due to new merged upstream ... again
-Odoo has new PR pull/105532 which fix the case where a module is
missing from database (ex : we delete it in the machine) then they
expect the icon will fallback to the icon of base module which is
currently correct but for base module, its icon is from our branding so
it failed the test 'test_missing_module_icon' because base module has
branding icon while 'missing' module has original base module icon.
-Why is that? it turn out to be the computation of method
'_get_icon_image' where we have this line
https://github.com/odoo/odoo/blob/c68df402703c67becc289eb992af64dfd007e3eb/odoo/addons/base/models/ir_module.py#L274
which then eventually go to this line
https://github.com/odoo/odoo/blob/c68df402703c67becc289eb992af64dfd007e3eb/odoo/modules/module.py#L343
which will execute method 'get_module_resource' in the original version
not from our overriden because it not something like
'modules.module.get_module_resource'
-Solution: override the method 'get_module_icon_path' to replace
'get_module_resource' with 'get_viin_brand_resource_path'
Branch:
15.0