V17 fix web qunit timeout website link tools tour
Killed
335m
merged
Commit message
[FIX] website: deflake link_tools tour when the editor activates blocks late test_15_website_link_tools fails at "Pick '/contactus" on the 17.0 runbot builds with every addon installed (226014: 3 attempts out of 3, 225958: 1 out of 2): the '/contactus (Contact Us)' suggestion is listed, but in a hidden dropdown. The editor activates the blocks the tour clicks one after the other. The tour clicks the image of the block, then the link of its text, and uses the link tools right away. On a loaded machine the activation of the link's block ends while the link tools already search suggestions. That activation first closes the widgets of the options it replaces, still the ones of the image, and closing the URL picker of the image hides the first website URL dropdown of the page: the one of the link tools. The searches that follow keep that hidden dropdown alive. Wait for the editor to show the options of the image after the click on it, then for the options of the link's block to replace them after the click on the link, before using the link tools. Reproduced on a database with 832 of the addons of the runbot build, with the suggestion requests slowed down to their runbot duration and the editor slowed down by debug logging: the tour failed at that step in 3 runs out of 8, each time right after the URL picker of the image had hidden the link tools dropdown, which it did in no passing run. With the waits it passed 6 runs out of 6 in the same conditions: the URL picker of the image still closed twice per run, always between the two waits, and never while the link tools were in use.