Name: [IMP] viin_brain,viin_web_editor: UI hardening v1 (token + polish + Odoo-native + v2 seams)

State: Failed finished in 15m

PR State: merged

PR Author: David Tran

PR Author Email:

PR: #27

Committer: David Tran

Committer Email: davidtran.hp@gmail.com

Commit: 0ea55a1fa96f031c3e53740a65818cb03a2f7e2b

Description:

                                            [FIX] viin_brain: P8 revert ShareDialog collab seam wiring (pre-existing Share crash)

P8 retroactive visual-evidence run captured ShareDialog crash on Share
button click (Odoo Client Error). Initial hypothesis: P7 added `<t
t-slot="collabSection"/>` caused regression. Root-cause analysis via
baseline test on `~/git/ai17` at branch 17.0 (no hardening changes)
showed identical crash hash on Share button click — **pre-existing
bug**, NOT introduced by P7.

Pre-existing crash blocks any in-place verification of the collab seam
wiring. Reverted the JS slots prop + XML t-slot:

  - share_dialog.js: removed `slots: { type: Object, optional: true,
    shape: { collabSection: ... } }` from static props.
  - share_dialog.xml: removed `<t t-slot="collabSection"/>` and the
    earlier guarded `<t t-if=...><t t-slot/></t>`. Replaced with a
    `<!-- v2 inject point -->` comment marker as anchor for v2
    xpath-inheritance.

Updated docs/brain/v2-extension-points.md (seam #4) to:
  - Mark seam as DOC-ONLY in v1.
  - Document v2 attach pattern requiring (a) fix pre-existing Share
    crash first, (b) patch ShareDialog props to add slots, (c) xpath
    inherit template to inject t-slot at the comment marker.

Other 5 P7 seams (presence palette, GraphPanel canvas mount, AIBlock
state registry, Property type registry, Decorator providers doc)
remain wired in v1 and verified via compiled-CSS evidence in P8
retroactive run (15x `0.15s ease` transitions, 68x `:focus-visible`
rules, 8x `--o-brain-presence-color-1..8` vars, etc.).

Phase: P8 convergence (visual-evidence retroactive)
Pipeline: 20260503-brain-ui-hardening-v1
Plan: ~/.claude/plans/parsed-spinning-peacock.md
                                            

Branch: 17.0

Instance ID: 0

Age:

Up-time:

Subbuilds Name State Detail
Build 381440 Check the quality with Pylint: from test_lint to test_pylint 15m Failed Log
Build 381441 At install tests: from account to website_twitter 130m Succeed Log
Build 381442 Post install tests: step install all modules 65m Succeed Log
Build 381443 Post install tests: from account to payment_alipay 163m Succeed Log
Build 381444 Post install tests: from payment_aps to test_viin_web_cohort 199m Succeed Log
Build 381445 Post install tests: from test_website to to_website_apps_store 79m Succeed Log
Build 381446 Post install tests: from to_website_apps_store_loc to viin_estimate_sale 89m Succeed Log
Build 381447 Post install tests: from viin_event_checkin_website to viin_project_gantt 39m Succeed Log
Build 381448 Post install tests: from viin_project_progress to website_twitter 49m Succeed Log
Build 381449 Test install all modules without demo data: from account to website_twitter 55m Succeed Log
Create Date Level Message
05/03/2026 16:40:10 INFO
Updated repository Viindoo-odoo
05/03/2026 16:40:10 INFO
Updated repository Viindoo-tvtmaaddons
05/03/2026 16:40:10 INFO
Updated repository Viindoo-erponline-enterprise
05/03/2026 16:40:10 INFO
Updated repository Viindoo-branding
05/03/2026 16:40:10 INFO
Cloned repository Viindoo-ai
05/03/2026 16:55:54 ERROR
Subbuild # 381440: odoo.addons.test_pylint.tests.test_eslint: FAIL: TestESLint.test_eslint Traceback (most recent call last): File "/data/build/Viindoo-tvtmaaddons-17.0/test_pylint/tests/test_eslint.py", line 67, in test_eslint self.assertEqual(process.returncode, 0, msg=f""" AssertionError: 1 != 0 : stdout: /data/build/rb-0ea55a1-221695/viin_brain/static/tests/seams/v2_extension_seams_tests.js 34:19 error Replace `⏎············mount.classList.contains("d-none"),⏎············"canvas·mount·is·hidden·by·default·(d-none)"⏎········` with `mount.classList.contains("d-none"),·"canvas·mount·is·hidden·by·default·(d-none)"` prettier/prettier 41:13 error Replace `"canvas·mount·declares·t-ref=\"canvasMount\""` with `'canvas·mount·declares·t-ref="canvasMount"'` prettier/prettier 56:16 error Replace `"Seam·4:·ShareDialog·template·has·empty·<t·t-slot=\"collabSection\"/>"` with `'Seam·4:·ShareDialog·template·has·empty·<t·t-slot="collabSection"/>'` prettier/prettier 60:45 error Replace `"exactly·one·<t·t-slot=\"collabSection\"/>·declared"` with `'exactly·one·<t·t-slot="collabSection"/>·declared'` prettier/prettier 83:16 error Replace `"Seam·6:·AI·block·HTML·output·carries·additive·o_brain_ai_state_<status>·class",` with `⏎········"Seam·6:·AI·block·HTML·output·carries·additive·o_brain_ai_state_<status>·class",⏎·······` prettier/prettier 84:1 error Replace `········` with `············` prettier/prettier 85:9 error Insert `····` prettier/prettier 86:1 error Replace `········` with `············` prettier/prettier 87:9 error Insert `····` prettier/prettier 88:1 error Insert `····` prettier/prettier 89:9 error Insert `····` prettier/prettier 90:1 error Insert `····` prettier/prettier 91:1 error Replace `········` with `············` prettier/prettier 92:1 error Insert `····` prettier/prettier 93:1 error Replace `············` with `················` prettier/prettier 94:9 error Insert `····` prettier/prettier 95:1 error Replace `········` with `············` prettier/prettier 96:9 error Insert `····` prettier/prettier 97:1 error Insert `····` prettier/prettier 98:13 error Insert `····` prettier/prettier 99:9 error Insert `····` prettier/prettier 100:1 error Replace `····}` with `········}⏎····` prettier/prettier ✖ 22 problems (22 errors, 0 warnings) 22 errors and 0 warnings potentially fixable with the `--fix` option. Perhaps you might benefit from installing the tooling found at: https://github.com/odoo/odoo/wiki/Javascript-coding-guidelines#use-a-linter stderr:
05/03/2026 16:55:54 ERROR
Subbuild # 381440: odoo.modules.loading: Module test_pylint: 1 failures, 0 errors of 7 tests
05/03/2026 16:55:54 ERROR
Subbuild # 381440: odoo.modules.loading: At least one test failed when loading the modules.
05/03/2026 16:55:54 ERROR
Subbuild # 381440: odoo.tests.result: 1 failed, 0 error(s) of 24 tests when loading database 'rb-0ea55a1-221695-381440'