Name:
[IMP] viin_ai_brain, viin_brain, docs: Brain Standard-17 closeout (11 tools + native OT + drift reconcile)
State:
Killed
finished in 219m
PR State:
merged
PR Author:
David Tran
PR Author Email:
PR:
#68
Committer:
David Tran
Committer Email:
davidtran.hp@gmail.com
Commit:
3dd722901d51d0b0dbe1575295e9391e2e2b37ea
Description:
[IMP] viin_brain: harden CW2 collab tests per code-review
Post-review hardening for PR #68 (review report
.odoo-ai/reviews/pr68-2026-06-22/viin_brain.md):
- test_brain_collab_activation_tour.py: make the native-collab precondition
deterministic so the tour's channel assertion actually runs instead of being
silently skipped - set the admin notification_type to 'inbox' in setUpClass
(drives session.notification_type truthy -> _hasICEServers ->
_isCollaborationEnabled). The assertion still FAILS when wiring is wrong
(collaborationChannel/busService remain required). Add tearDownClass to
restore notification_type and reset realtime_collab=False (no state leak).
- test_brain_collab_block_roundtrip.py: exercise the real ORM path
(write content_html/blocks -> re-read) instead of calling the private
_derive_from_* helpers directly, keeping the suite red-able.
- test_brain_realtime_collab.py: assertEqual(stored, 'True') (exact) instead
of a permissive membership check.
- brain_collab_activation_tour.js: keep the canonical
odoo.loader.modules.get(...) pattern (matches Odoo 17 core rte.js; require()
is not a global in tour run callbacks) - add a comment to prevent re-flagging.
Review finding F-1 (switch to require) was a false positive.
- CHANGELOG.md: link ADR-002 for traceability.
Browser tour verified by Runbot (headless tour not runnable locally).
Branch:
17.0
Instance ID:
0
Age:
Up-time: