PR State:
merged
PR:
#664
Commit:
d5d061cf13415d4119333a93be42d3156419fc3b
[FWD] forward-port 18.0 -> 19.0 (0dafec5..467ac60, 9 commits)
Absorbs every commit that landed on 18.0 since the last forward-port, so the
merge-base advances and none of them is reconsidered next run.
Three carry real behaviour to 19.0:
* viin_brand_website no longer replaces website.layout's x_icon producer. That
xpath resolved to core's own producer and destroyed it, so a customer who
configured their own favicon could never serve it. Branding now comes from a
field default in models/website.py: a new website starts branded, and the
customer's value wins the moment they set one. Locked by
tests/test_website_favicon_not_preempted.py.
* viin_backend_theme guards _loadDefaultApp before diverting to the home menu,
so an environment with a cleaned action registry falls back to the stock
default app instead of throwing during boot.
* viin_brand_website_sale drops the unverifiable "#1" ranking claim from the
eCommerce promo, in the template and both translation catalogs.
The rest are absorbed without adapt because 19.0 already moved past them:
web_responsive is gone entirely, replaced by viin_backend_theme; QUnit is
replaced by Hoot; the web.layout title/favicon fallback was deliberately
re-homed onto that template's callers and must not be restored.
One auto-merge carried a symbol that no longer exists here: the window-title
branding arrived guarded by session.viin_brand, a marker stamped by an
ir.http.session_info override 19.0 does not have, which would have left the
title permanently unbranded with no error. Reverted to the 19.0 version.
Signed-off-by: David Tran <david.tran@tvtmarine.com>
Branch:
19.0