PR State:
open
PR:
#649
Commit:
9e5266f880ee2368b9724ea6f967de282f14484b
[FIX] web_responsive: correct a false idempotency comment + bind the session_info test
Three review findings from the forward-port batch.
The migration's comment claimed the is_redirect_home filter makes a re-run
match nothing, so an opted-out user is never silently re-opted-in. The second
half was false: an opted-out user holds False, which is exactly what the
domain selects. Odoo compiles a boolean "= False" to
(col IS NULL OR col = FALSE), so the domain provably cannot tell "never
backfilled" from "deliberately opted out" - the manifest version gate is what
makes this run once. The comment now says that. The domain and the logic are
unchanged and correct: that same collapse is what lets the backfill match the
NULL rows every pre-existing user actually has.
test_session_info only ever exercised the preference at True, so a hardcoded
True in the session_info transport would have passed it. It now also flips the
preference to False and re-asserts, binding the assertion to the user's real
stored value on both sides.
The new JS test file carried an OCA sibling's copyright header; it is
Viindoo's own 2026 file. The LGPL-3 license line stays - the module is OCA.
Branch:
18.0