PR State:
merged
PR:
#1248
Commit:
13a8d7f8ce87abe3bd5014bbf7970464ebe2a7e6
[FIX] website: deflake snippet_empty_parent_autoremove tour
The customize panel is rebuilt asynchronously (behind the edition mutex)
after every selection change or removal, and the stale panel of the
previous selection has the same shape as the fresh one. The bare
:nth-last-child(3) trigger of 'Remove selected block' can match the
stale panel while its editor is being destroyed; the click is then
silently swallowed, the column stays in place and the tour times out on
'Check that #wrap is empty' on loaded hosts.
Scope the remove trigger to a panel actually showing the Column options
(every use of the helper removes a Column block and the stale panel of
its parent snippet has no such block), and wait for the second column to
leave the iframe DOM before selecting the first one - the column and its
options panel are removed in the same synchronous block of
removeSnippet, so this guarantees the stale panel is gone.
Reproduced on a stock database under host load (2/3 failures with
stepDelay=0); consistently green with this change.
Branch:
17.0