PR State:
merged
PR:
#671
Commit:
242d9918ab087d5c479a463a2f5b4e5002eecc42
[FIX] web_responsive: reach the apps menu the user actually opens
e2e5205 split the apps-menu screen into two sibling classes -
AppsMenuAction (still registered under the "menu" actions tag, the
class third-party modules patch by name) and AppsMenuOverlay (what
appsMenuService.toggleMenu() actually mounts for the user, via the
overlay service). Because the overlay was a SIBLING of AppsMenuAction
rather than a descendant, a module that does
patch(AppsMenuAction.prototype, {...}) and separately extends the
shared "web_responsive.AppsMenuAction" template by name - the real,
shipped shape in erponline-enterprise/viin_customizer_web_responsive -
never reached the class that renders for the user. Runbot build
224030 failed 71 of 83 tests with "TypeError: ctx.getAppCreatorItem is
not a function at AppsMenuOverlay.slot2": every tour that opens the
apps menu died.
Make AppsMenuOverlay extend AppsMenuAction instead of the shared
AppsMenuScreen base, so a prototype patch() applied to AppsMenuAction
- by this module or any third party, in either load order - is
inherited by the overlay too. Corrected what plain inheritance would
otherwise get wrong on the new subclass: static props (an overlay's
shape, not the action-service props it would otherwise inherit),
coversNothing (the overlay has no env.config to read breadcrumbs
from, so it falls back to the base class's own resolution), and left
static target/displayName inherited-but-inert with a comment so a
future reader does not "clean them up" and reopen this. Documented at
the class declarations that AppsMenuAction is both the "menu" action-
tag registrant and the patch target other modules reach for by name,
so the next module that legally patches this class does not silently
break again.
This repairs a regression we shipped, already merged into 18.0
(origin/18.0 @ 2cfee94 contains e2e5205). The suite was NOT executed
here: this fix was produced under a static-verification-only
constraint (no instance, no odoo-bin, no database, no test run). RED
was argued from source - traced against e2e5205's diff and the real
external patcher/template-inheritor - and the fix confirmed by static
reasoning over the JS prototype chain (AppsMenuOverlay.prototype's
[[Prototype]] is a live reference to AppsMenuAction.prototype, so a
patch() mutation to the latter is visible to overlay instances).
Syntax-checked with node --input-type=module --check; no reachable
project ESLint config to run further here - that gate runs later at
the run's own pre-PR tail.
Branch:
18.0
Odoo 18 Test Suite Using Docker
Check the quality with Pylint: from test_lint to test_pylint
- install_module test_lint,test_pylint
- exec_odoo --db_port 5432 --log-level=test --max-cron-threads=0 --load=base,web,to_base --stop-after-init --test-enable --test-tags=/test_lint,/test_pylint,/test_lint,/test_pylint,-:.test_pofiles_string_formatting
| Create Date | Level | Message |
|---|---|---|
| 08/19/2026 04:10:30 | INFO |
Using Docker Image Odoo 18 Ubuntu 24.04 Python 3.12:
FROM ubuntu:noble ENV LANG C.UTF-8 ENV ODOO_TEST_FAILURE_RETRIES=2 # Retrieve the target architecture to install the correct wkhtmltopdf package ARG TARGETARCH USER root SHELL ["/bin/bash", "-c"] # Install debian packages RUN set -x ; \ apt-get update \ && DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends apt-transport-https build-essential ca-certificates curl file fonts-freefont-ttf fonts-noto-cjk gawk gnupg gsfonts libldap2-dev libjpeg9-dev libsasl2-dev libxslt1-dev lsb-release npm ocrmypdf sed sudo unzip xfonts-75dpi zip zlib1g-dev software-properties-common git \ && rm -rf /var/lib/apt/lists/* # Install Python3 packages RUN set -x ; \ apt-get update \ && DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends publicsuffix python3 flake8 python3-dbfread python3-dev python3-gevent python3-pip python3-setuptools python3-wheel python3-markdown python3-mock python3-phonenumbers python3-websocket python3-google-auth libpq-dev pylint python3-jwt python3-asn1crypto python3-html2text python3-suds python3-xmlsec \ && rm -rf /var/lib/apt/lists/* # Install wkhtml RUN curl -o xfonts-base.deb http://archive.ubuntu.com/ubuntu/pool/main/x/xfonts-base/xfonts-base_1.0.5+nmu1_all.deb && dpkg -i xfonts-base.deb RUN curl -o wkhtmltox.deb -sSL https://github.com/wkhtmltopdf/packaging/releases/download/0.12.6.1-3/wkhtmltox_0.12.6.1-3.jammy_amd64.deb \ && apt-get install -y --no-install-recommends ./wkhtmltox.deb \ && rm -rf /var/lib/apt/lists/* wkhtmltox.deb xfonts-base.deb # Install Odoo:Depends ADD https://raw.githubusercontent.com/brendangregg/FlameGraph/master/flamegraph.pl /usr/local/bin/flamegraph.pl RUN chmod +rx /usr/local/bin/flamegraph.pl # Github bị 429, ADD https://raw.githubusercontent.com/Viindoo/odoo/18.0/debian/control /tmp/control.txt ADD https://github.com/royle-vietnam/odoo/releases/download/odoo/control2 /tmp/control.txt RUN apt-get update \ && sed -n '/^Depends:/,/^[A-Z]/p' /tmp/control.txt \ | awk '/^ [a-z]/ { gsub(/,/,"") ; print $1 }' | sort -u \ | egrep -v 'postgresql-client' \ | sed 's/python-imaging/python-pil/'| sed 's/python-pypdf/python-pypdf2/' | sed 's/python3-lxml-html-clean/python3-lxml/' \ | DEBIAN_FRONTEND=noninteractive xargs apt-get install -y -qq \ && apt-get clean \ && rm -rf /var/lib/apt/lists/* RUN python3 -m pip install --break-system-packages --no-cache-dir setuptools wheel && \ python3 -m pip install --break-system-packages coverage==7.4.4 flamegraph # install latest postgresql-client RUN echo 'deb http://apt.postgresql.org/pub/repos/apt/ noble-pgdg main' > /etc/apt/sources.list.d/pgdg.list \ && GNUPGHOME="$(mktemp -d)" \ && export GNUPGHOME \ && repokey='B97B0AFCAA1A47F044F244A07FCC7D46ACCC4CF8' \ && gpg --batch --keyserver keyserver.ubuntu.com --recv-keys "${repokey}" \ && gpg --batch --armor --export "${repokey}" > /etc/apt/trusted.gpg.d/pgdg.gpg.asc \ && gpgconf --kill all \ && rm -rf "$GNUPGHOME" \ && apt-get update \ && apt-get install --no-install-recommends -y postgresql-client \ && rm -f /etc/apt/sources.list.d/pgdg.list \ && rm -rf /var/lib/apt/lists/* # Install Google Chrome ARG CHROME_VERSION=150.0.7871.114 RUN set -eux; \ echo 'repo_add_once="false"' > /etc/default/google-chrome; \ curl -sSLf "https://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_${CHROME_VERSION}-1_amd64.deb" \ -o /tmp/chrome.deb; \ apt-get update; \ apt-get -y install --no-install-recommends /tmp/chrome.deb; \ apt-mark hold google-chrome-stable; \ rm -f /tmp/chrome.deb /etc/apt/sources.list.d/google-chrome.list; \ rm -rf /var/lib/apt/lists/*; \ google-chrome --version | grep -F "${CHROME_VERSION}" # Install phantomjs RUN curl -sSL https://nightly.odoo.com/resources/phantomjs.tar.bz2 -o /tmp/phantomjs.tar.bz2 \ && tar xvfO /tmp/phantomjs.tar.bz2 phantomjs-2.1.1-linux-x86_64/bin/phantomjs > /usr/local/bin/phantomjs \ && chmod +x /usr/local/bin/phantomjs \ && rm -f /tmp/phantomjs.tar.bz2 ENV PIP_BREAK_SYSTEM_PACKAGES=1 # Github bị 429, ADD https://raw.githubusercontent.com/Viindoo/odoo/18.0/requirements.txt /root/requirements.txt ADD https://github.com/royle-vietnam/odoo/releases/download/odoo/requirements.txt /root/requirements.txt RUN python3 -m pip install --break-system-packages --no-cache-dir setuptools wheel && \ python3 -m pip install --break-system-packages --upgrade --force-reinstall --ignore-installed --no-cache-dir -r /root/requirements.txt && \ python3 -m pip install --no-cache-dir ebaysdk==2.1.5 pdf417gen==0.7.1 RUN python3 -m pip install --break-system-packages --no-cache-dir requests pyOpenSSL # Install debian packages RUN set -x ; \ apt-get update \ && DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends openssl iputils-ping openssh-client chromium-browser \ && rm -rf /var/lib/apt/lists/* RUN python3 -m pip install --no-cache-dir --upgrade websocket-client==1.2.3 flake8==6.1.0 #RUN python3 -m pip uninstall pylint pylint-odoo isort Pygments -y RUN python3 -m pip install --break-system-packages --upgrade --force-reinstall --ignore-installed --no-cache-dir --upgrade pylint-odoo==9.0.5 RUN python3 -m pip install --break-system-packages --upgrade --force-reinstall --ignore-installed --no-cache-dir --upgrade Pygments==2.15.0 --no-deps # Install nodejs RUN curl -fsSLO --compressed "https://nodejs.org/dist/v18.20.0/node-v18.20.0-linux-x64.tar.xz" \ && tar -xJf "node-v18.20.0-linux-x64.tar.xz" -C /usr/local --strip-components=1 --no-same-owner \ && rm "node-v18.20.0-linux-x64.tar.xz" \ && ln -s /usr/local/bin/node /usr/local/bin/nodejs RUN npm install -g rtlcss@3.4.0 es-check@6.0.0 eslint@8.57.1 prettier@2.7.1 eslint-config-prettier@8.5.0 eslint-plugin-prettier@4.2.1 # Tránh warning do bug của ubuntu RUN rm -rf /usr/lib/python3.12/dist-packages/charset_normalizer-3.3.2.dist-info # Install cloc package RUN set -x ; \ apt-get update \ && DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends cloc pv \ && rm -rf /var/lib/apt/lists/* |
| 08/19/2026 04:10:30 | INFO |
Check the quality with Pylint: from test_lint to test_pylint:
Command: install_module args: test_lint,test_pylint |
| 08/19/2026 04:10:30 | INFO |
Check the quality with Pylint: from test_lint to test_pylint:
Command: exec_odoo args: --db_port 5432 --log-level=test --max-cron-threads=0 --load=base,web,to_base --stop-after-init --test-enable --test-tags=/test_lint,/test_pylint,/test_lint,/test_pylint,-:.test_pofiles_string_formatting |
| 08/19/2026 04:10:30 | INFO |
Docker command:
cd /data/build; python3 -m pip install --user --no-cache-dir --progress-bar off -r Viindoo-tvtmaaddons-18.0/requirements.txt && python3 -m pip install --user --no-cache-dir --progress-bar off -r Viindoo-erponline-enterprise-18.0/requirements.txt && python3 Viindoo-odoo-18.0/odoo-bin --addons-path Viindoo-odoo-18.0/odoo/addons,Viindoo-odoo-18.0/addons,Viindoo-tvtmaaddons-18.0,Viindoo-erponline-enterprise-18.0,rb-242d991-224035 -d rb-242d991-224035-405377 --data-dir /data/build/datadir -i test_lint,test_pylint --db_port 5432 --log-level=test --max-cron-threads=0 --load=base,web,to_base --stop-after-init --test-enable --test-tags=/test_lint,/test_pylint,/test_lint,/test_pylint,-:.test_pofiles_string_formatting ; |
| 08/19/2026 04:10:30 | INFO |
Container rb-242d991-224035-405377 started !
|
| 08/19/2026 04:25:41 | INFO |
Container rb-242d991-224035-405377 stopped !
|
| 08/19/2026 04:25:41 | WARNING |
py.warnings: /data/build/Viindoo-odoo-18.0/odoo/modules/registry.py:677: UserWarning: PostgreSQL function 'unaccent' is present but not immutable, therefore trigram indexes may not be effective.
File "/data/build/Viindoo-odoo-18.0/odoo-bin", line 8, in <module> odoo.cli.main() File "/data/build/Viindoo-odoo-18.0/odoo/cli/command.py", line 76, in main o.run(args) File "/data/build/Viindoo-odoo-18.0/odoo/cli/server.py", line 182, in run main(args) File "/data/build/Viindoo-odoo-18.0/odoo/cli/server.py", line 175, in main rc = odoo.service.server.start(preload=preload, stop=stop) File "/data/build/Viindoo-odoo-18.0/odoo/service/server.py", line 1510, in start rc = server.run(preload, stop) File "/data/build/Viindoo-odoo-18.0/odoo/service/server.py", line 644, in run rc = preload_registries(preload) File "/data/build/Viindoo-odoo-18.0/odoo/service/server.py", line 1414, in preload_registries registry = Registry.new(dbname, update_module=update_module) File "/usr/local/lib/python3.12/dist-packages/decorator/__init__.py", line 247, in fun return caller(func, *(extras + args), **kw) File "/data/build/Viindoo-odoo-18.0/odoo/tools/func.py", line 97, in locked return func(inst, *args, **kwargs) File "/data/build/Viindoo-odoo-18.0/odoo/modules/registry.py", line 116, in new odoo.modules.load_modules(registry, force_demo, status, update_module) File "/data/build/Viindoo-odoo-18.0/odoo/modules/loading.py", line 489, in load_modules processed_modules += load_marked_modules(env, graph, File "/data/build/Viindoo-odoo-18.0/odoo/modules/loading.py", line 365, in load_marked_modules loaded, processed = load_module_graph( File "/data/build/Viindoo-odoo-18.0/odoo/modules/loading.py", line 206, in load_module_graph registry.init_models(env.cr, model_names, {'module': package.name}, new_install) File "/data/build/Viindoo-odoo-18.0/odoo/modules/registry.py", line 610, in init_models self.check_indexes(cr, model_names) File "/data/build/Viindoo-odoo-18.0/odoo/modules/registry.py", line 677, in check_indexes warnings.warn( |
| 08/19/2026 04:25:41 | INFO |
Cleaning all resource
|
| 08/19/2026 04:25:41 | INFO |
Cleanup finished
|