Name: [FIX] web_responsive: don't break core component tests when apps_menu is

State: Killed

PR State: merged

PR Author: Roy Le

PR Author Email:

PR: #646

Committer: Roy Le

Committer Email: roy.le@viindoo.com

Commit: dbed0ffccf452bc4a5bd1062729a2f1ab4a771af

Description:

                                            [FIX] web_responsive: don't break core component tests when apps_menu is
absent

The NavBar and WebClient patches called useService("apps_menu") and the
menu searchbar read session.apps_menu.search_type. Isolated core
component tests (NavBar, BurgerMenu, mail mobile) do not start apps_menu
nor set session.apps_menu, so these threw as soon as web_responsive is
installed ("Service apps_menu is not available", "Cannot read properties
of undefined (reading 'search_type')"). Read apps_menu from env.services
(optional), fall back to super._loadDefaultApp(), and use
session.apps_menu?.search_type.
                                            

Branch: 17.0

Instance ID: 0

Age:

Up-time: Not finished