PR State:
merged
PR:
#678
Commit:
ed47c50bb1fad5652de9f41d3c35349615eb4a41
[FIX] viin_brand_crm: depend on viin_brand_digest to fix install-order crash
Installing modules in some environments could abort partway through with:
ParseError: .../viin_brand_crm/data/digest_data.xml:5
ValueError: Invalid field 'active' on model 'digest.tip'
digest_data.xml writes digest.tip.active, but that field is defined by the
sibling module viin_brand_digest, not by viin_brand_crm or by crm. Both
modules are auto_install: True with no dependency edge between them, so
Odoo's loader has no ordering guarantee and can process viin_brand_crm
before viin_brand_digest has added the field - observed on a real build
aborting at module 72 of 126.
Add viin_brand_digest to viin_brand_crm's depends so the loader is forced
to install it first. This does not widen who gets auto-installed: core crm
already depends on digest, so whenever crm is installed, digest is
installed too, which means viin_brand_digest (depends ['digest'],
auto_install) was already an install candidate in exactly the same
situations. The new edge only constrains order, which is precisely what
was missing.
digest_data.xml itself is untouched - the data is correct; it was only
running too early.
Branch:
18.0