PR State:
merged
PR:
#673
Commit:
46c68b35625fe78e4ecfaff09998d574604ba18b
[FIX] viin_brand_onboarding: drop own SCSS from core's JS unit-test bundles
viin_brand_onboarding was the one brand module the earlier four-module
sweep missed. Its onboarding.scss reads five brand variables that only
viin_brand_common defines - $brand-primary-light/-dark/-darker and
$brand-secondary-light/-dark - and that web.assets_unit_tests_setup and
web.tests_assets no longer carry now that viin_brand_common's own
sweep removed them. So this leak did not merely pollute core's JS unit
tests with Viindoo design tokens, it aborted the compile of the whole
bundle with "Undefined variable".
Remove this module's own stylesheet from those two TEST-ONLY bundles;
web.assets_backend (the real webclient) is untouched and still serves
the stylesheet with all 18 brand gradient declarations byte-identical.
New tests guard both directions.
Measured: before 7 failed of 21 tests (14 "Undefined variable"
occurrences), after 1 failed of 21 (0 "Undefined variable"). The one
remaining failure is unrelated and pre-existing: a sibling guard test
that needs point_of_sale or hr_attendance installed to verify
anything, and correctly refuses to pass vacuously when neither is.
Signed-off-by: David Tran <david.tran@tvtmarine.com>
Branch:
18.0