PR State:
merged
PR:
#673
Commit:
e2803fc5b8c63a88f3db3190ed6522ebf5586735
[FIX] web_responsive: guard responsive layout now unit tests carry no brand CSS
The previous commits on this branch stripped web_responsive's own SCSS
back out of core's Hoot/QUnit test bundles, which fixed core tests that
were measuring this module's layout instead of core's own defaults - but
also removed the only place a regression that silently drops this
module's SCSS from the real webclient would have been noticed.
Add test_brand_css_out_of_test_bundles.py (2 tests): assert
web_responsive.scss is absent from web.assets_unit_tests_setup and
web.tests_assets (what the prior commit fixed) while still present in
web.assets_web, the bundle the real webclient is served from - so a
future change cannot silently strip the responsive layout from
production while the test bundles stay clean. The module marker is
matched on the full SCSS-compiler comment path, not a bare module-name
substring, since this database also carries
viin_customizer_web_responsive whose own stylesheet legitimately sits in
the test bundle and would otherwise report a false leak.
Verified live on a real instance: baseline 0 failed of 18, an inversion
that comments out this module's own ('remove', ...) manifest entry takes
down this guard specifically, and a restore-verify pass returns to 0
failed with all tours succeeding.
Branch:
18.0