PR State:
merged
PR:
#693
Commit:
133655dc2532cf9269c8bd5207554f14d31d10c4
[FIX] viin_backend_theme: keep apps menu open while app reloads
Opening the apps menu from the navbar while an app was still reloading
(for example clicking the app brand and then the apps button before the
screen finished loading) closed the menu before its tiles appeared, so
the user saw nothing to pick an app from. It broke the runbot
hr_expense tour create_expense_no_employee_access_tour (step 13/13,
.o_app tile not found, 4 failures out of 5 runs).
Cause: NavBar.setup() closed the menu overlay on every
ACTION_MANAGER:UI-UPDATED. The reload started by the brand click
finished while the overlay's ViinHomeMenu was still in onWillStart (its
mail.activity search_count and res.users read RPCs), so the overlay
entry was removed before any tile was mounted.
The UI-UPDATED listener is removed. The menu is still closed by a route
change, outside click, Escape and when the navbar is destroyed; the
mobile "All Apps" guard that refuses to open a menu before any screen
exists is unchanged.
Tests: a Hoot desktop test holds the list reload and the menu's own
RPCs and requires the overlay and its app tiles to be on screen once
both finish; it fails with the listener and passes without it. The
mobile test that faked a screen to assert the removed close is dropped;
the real guard stays covered by "All Apps tapped while the boot app menu
is still loading opens no overlay and the toggle keeps working".
Signed-off-by: David Tran <david.tran@tvtmarine.com>
Branch:
19.0