Name:
[FIX] dark mode: readable pivot/graph, dark spreadsheet and dashboard chrome, calmer Discuss seams
State:
Killed
finished in 172m
PR State:
merged
PR Author:
David Tran
PR Author Email:
PR:
#680
Committer:
David Tran
Committer Email:
david.tran@tvtmarine.com
Commit:
f03cc36358e9c780ac4d4957b092a0545f702972
Description:
[FIX] viin_backend_theme: dedupe the active marker in the Appearance menu
The Appearance systray menu's active Theme row and active Density row each
drew two selected-markers: core's own `.dropdown-item.active::before`
FontAwesome checkmark painted on top of this component's own right-aligned
check icon, so the active choice showed a double mark instead of one.
Core's marker is suppressed on both DropdownItem loops with core's own
opt-out class `dropdown-item_active_noarrow`, leaving the component's own
check as the single indicator. mail's action list already reuses that class
for the identical situation, so this reuses an existing core lever instead
of inventing new CSS.
A tour-driven HttpCase asserts the rendered result - the active row's
computed `::before` is 'none' and exactly one visible `.fa-check` remains
inside it - in both the light and the dark colour scheme, so the contract
is pinned on render output rather than on markup.
Signed-off-by: David Tran <david.tran@tvtmarine.com>
Branch:
19.0
Age:
Up-time: