PR State:
merged
PR:
#22
Commit:
bfce74a14cd125b9f91ecabd7cbfb6926393fec6
[REF] viin_brain: drop transient sequence field, order collab steps by id (H3+M5)
The previous _append_step read the latest sequence and wrote
last.sequence + 1 with no row lock. Two concurrent transactions
appending to the same page therefore raced — both saw the same
"last" record and both tried to insert the next sequence value,
producing duplicate sequences (and an inconsistent replay order
on reconnect).
Drop the sequence field entirely and rely on the auto-incremented
id column. PostgreSQL id is monotonic per-table, which is exactly
what a relay buffer needs: stable replay order across reconnects.
The buffer is not authoritative history (the source of truth is
viin.brain.page.content_html), so gap-free numbering is not a
requirement; only deterministic ordering is.
Migration: TransientModel column drop is handled by the ORM at
_auto_init during module update — no manual migration script
needed. New code never references sequence so prune logic and
history shape continue to work after the column disappears.
Also move the json import in viin_brain_collab_step.py to the
module top so it does not happen on every _get_history call (M5).
Tests:
- test_append_step_single: drop sequence assertion.
- test_append_step_ordering: rewrite to verify id order matches
the order callers invoked _append_step (and that step_json
payloads come back in append order).
- test_rolling_window_trim: verify pruning by inspecting
surviving step_json values rather than sequence numbers.
- test_get_history_order_and_shape: drop sequence key assertion;
add explicit append-order assertion across client_id values.
- test_history_endpoint_returns_steps: drop sequence key assertion.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Branch:
17.0
Odoo 17 Test Suite Using Docker
Check the quality with Pylint: from test_lint to test_pylint
- install_module test_lint,test_pylint
- exec_odoo --db_port 5432 --log-level=test --max-cron-threads=0 --load=base,web,to_base --stop-after-init --test-enable --test-tags=/test_lint,/test_pylint,/test_lint,/test_pylint,-:.test_pofiles_string_formatting
| Create Date | Level | Message |
|---|---|---|
| 05/02/2026 01:25:20 | INFO |
Using Docker Image Odoo 17 Ubuntu 22.04 Python 3.10:
FROM ubuntu:jammy ENV LANG C.UTF-8 USER root SHELL ["/bin/bash", "-c"] # Install debian packages RUN set -x ; \ apt-get update \ && DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends apt-transport-https build-essential ca-certificates curl ffmpeg file fonts-freefont-ttf fonts-noto-cjk gawk gnupg gsfonts libldap2-dev libjpeg9-dev libsasl2-dev libxslt1-dev lsb-release node-less ocrmypdf sed sudo unzip xfonts-75dpi zip zlib1g-dev git build-essential cython3 libffi-dev libev-dev \ && rm -rf /var/lib/apt/lists/* # Install Python3 packages RUN set -x ; \ apt-get update \ && DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends python3 python3-dbfread python3-dev python3-pip python3-setuptools python3-wheel python3-markdown python3-mock python3-phonenumbers python3-websocket python3-cffi libpq-dev \ && rm -rf /var/lib/apt/lists/* # Install wkhtml RUN curl -sSL https://github.com/wkhtmltopdf/packaging/releases/download/0.12.6-1/wkhtmltox_0.12.6-1.focal_amd64.deb -o /tmp/wkhtmltox_0.12.6-1.focal_amd64.deb \ && curl -sSL http://archive.ubuntu.com/ubuntu/pool/main/o/openssl/libssl1.1_1.1.0g-2ubuntu4_amd64.deb -o /tmp/libssl1.1_1.1.0g-2ubuntu4_amd64.deb \ && apt-get update \ && dpkg -i /tmp/libssl1.1_1.1.0g-2ubuntu4_amd64.deb \ && apt install -y -f --no-install-recommends /tmp/wkhtmltox_0.12.6-1.focal_amd64.deb \ && rm /tmp/libssl1.1_1.1.0g-2ubuntu4_amd64.deb /tmp/wkhtmltox_0.12.6-1.focal_amd64.deb # Install Odoo:Depends ADD https://raw.githubusercontent.com/brendangregg/FlameGraph/master/flamegraph.pl /usr/local/bin/flamegraph.pl RUN chmod +rx /usr/local/bin/flamegraph.pl ADD https://raw.githubusercontent.com/Viindoo/odoo/17.0/debian/control /tmp/control.txt RUN apt-get update \ && sed -n '/^Depends:/,/^[A-Z]/p' /tmp/control.txt \ | awk '/^ [a-z]/ { gsub(/,/,"") ; print $1 }' | sort -u \ | egrep -v 'postgresql-client' \ | sed 's/python-imaging/python-pil/'| sed 's/python-pypdf/python-pypdf2/' | sed 's/python3-lxml-html-clean/python3-lxml/' \ | DEBIAN_FRONTEND=noninteractive xargs apt-get install -y -qq \ && apt-get clean \ && rm -rf /var/lib/apt/lists/* RUN python3 -m pip install --no-cache-dir setuptools wheel && \ python3 -m pip install coverage==7.4.4 flamegraph RUN apt-get update \ && DEBIAN_FRONTEND=noninteractive apt-get install -y postgresql-client-14 \ && rm -rf /var/lib/apt/lists/* # Install Google Chrome #RUN curl -sSL https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb -o /tmp/chrome.deb \ # && apt-get update \ # && apt-get -y install --no-install-recommends /tmp/chrome.deb \ # && rm /tmp/chrome.deb # Install phantomjs RUN curl -sSL https://nightly.odoo.com/resources/phantomjs.tar.bz2 -o /tmp/phantomjs.tar.bz2 \ && tar xvfO /tmp/phantomjs.tar.bz2 phantomjs-2.1.1-linux-x86_64/bin/phantomjs > /usr/local/bin/phantomjs \ && chmod +x /usr/local/bin/phantomjs \ && rm -f /tmp/phantomjs.tar.bz2 ADD https://raw.githubusercontent.com/Viindoo/odoo/17.0/requirements.txt /root/requirements.txt RUN python3 -m pip install --no-cache-dir wheel setuptools && \ python3 -m pip install --upgrade --no-cache-dir -r /root/requirements.txt && \ python3 -m pip install --no-cache-dir ebaysdk==2.1.5 pdf417gen==0.7.1 RUN python3 -m pip install --no-cache-dir requests pyOpenSSL # Install debian packages RUN set -x ; \ apt-get update \ && DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends openssl iputils-ping openssh-client chromium-browser \ && rm -rf /var/lib/apt/lists/* RUN python3 -m pip install --no-cache-dir --upgrade websocket-client==1.2.3 flake8==4.0.1 RUN python3 -m pip uninstall pylint pylint-odoo isort Pygments -y RUN python3 -m pip install --no-cache-dir --upgrade pylint-odoo==9.0.5 RUN python3 -m pip install --no-cache-dir --upgrade Pygments==2.14.0 --no-deps RUN python3 -m pip install --no-cache-dir --upgrade odoo_test_helper # Install nodejs RUN curl -fsSLO --compressed "https://nodejs.org/dist/v18.20.0/node-v18.20.0-linux-x64.tar.xz" \ && tar -xJf "node-v18.20.0-linux-x64.tar.xz" -C /usr/local --strip-components=1 --no-same-owner \ && rm "node-v18.20.0-linux-x64.tar.xz" \ && ln -s /usr/local/bin/node /usr/local/bin/nodejs #RUN npm install -g rtlcss es-check eslint@8 RUN python3 -m pip install --no-cache-dir --upgrade setuptools==61 # để tương thích với python-pkcs11-0.7.0 # Install cloc package RUN set -x ; \ apt-get update \ && DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends cloc \ && rm -rf /var/lib/apt/lists/* RUN npm install -g rtlcss@3.4.0 es-check@6.0.0 eslint@8.57.1 prettier@2.7.1 eslint-config-prettier@8.5.0 eslint-plugin-prettier@4.2.1 --save-dev |
| 05/02/2026 01:25:20 | INFO |
Docker command:
cd /data/build; python3 -m pip install --user --progress-bar off -r Viindoo-tvtmaaddons-17.0/requirements.txt && python3 -m pip install --user --progress-bar off -r Viindoo-erponline-enterprise-17.0/requirements.txt && python3 Viindoo-odoo-17.0/odoo-bin --addons-path Viindoo-odoo-17.0/odoo/addons,Viindoo-odoo-17.0/addons,Viindoo-tvtmaaddons-17.0,Viindoo-erponline-enterprise-17.0,Viindoo-branding-17.0,rb-bfce74a-221677 -d rb-bfce74a-221677-381264 --data-dir /data/build/datadir -i test_lint,test_pylint --db_port 5432 --log-level=test --max-cron-threads=0 --load=base,web,to_base --stop-after-init --test-enable --test-tags=/test_lint,/test_pylint,/test_lint,/test_pylint,-:.test_pofiles_string_formatting ; |
| 05/02/2026 01:25:20 | INFO |
Container rb-bfce74a-221677-381264 started !
|
| 05/02/2026 01:45:24 | INFO |
Container rb-bfce74a-221677-381264 stopped !
|
| 05/02/2026 01:45:24 | ERROR |
odoo.addons.test_pylint.tests.test_eslint: FAIL: TestESLint.test_eslint
Traceback (most recent call last):
File "/data/build/Viindoo-tvtmaaddons-17.0/test_pylint/tests/test_eslint.py", line 67, in test_eslint
self.assertEqual(process.returncode, 0, msg=f"""
AssertionError: 1 != 0 :
stdout:
/data/build/rb-bfce74a-221677/viin_brain/static/tests/services/collab_step_service_filter_tests.js
39:45 error Replace `{},` with `⏎········{},⏎·······` prettier/prettier
40:9 error Insert `····` prettier/prettier
41:9 error Insert `····` prettier/prettier
42:1 error Replace `····}` with `········}⏎····` prettier/prettier
68:12 error Replace `"handler·drops·notifications·missing·page_id·(legacy/malformed·payload)",` with `⏎····"handler·drops·notifications·missing·page_id·(legacy/malformed·payload)",⏎···` prettier/prettier
69:1 error Insert `····` prettier/prettier
70:1 error Replace `····const·service·=·collabStepService.start({},` with `········const·service·=·collabStepService.start(⏎············{},⏎···········` prettier/prettier
71:1 error Insert `········` prettier/prettier
72:1 error Replace `········` with `················` prettier/prettier
73:5 error Replace `}` with `········}⏎········` prettier/prettier
75:1 error Insert `····` prettier/prettier
76:1 error Insert `····` prettier/prettier
78:1 error Replace `····` with `········` prettier/prettier
79:1 error Insert `····` prettier/prettier
80:9 error Insert `····` prettier/prettier
81:1 error Replace `········` with `············` prettier/prettier
82:5 error Insert `····` prettier/prettier
84:1 error Insert `····` prettier/prettier
85:1 error Replace `}` with `····}⏎` prettier/prettier
✖ 19 problems (19 errors, 0 warnings)
19 errors and 0 warnings potentially fixable with the `--fix` option.
Perhaps you might benefit from installing the tooling found at:
https://github.com/odoo/odoo/wiki/Javascript-coding-guidelines#use-a-linter
stderr:
|
| 05/02/2026 01:45:24 | ERROR |
odoo.modules.loading: Module test_pylint: 1 failures, 0 errors of 7 tests
|
| 05/02/2026 01:45:24 | ERROR |
odoo.modules.loading: At least one test failed when loading the modules.
|
| 05/02/2026 01:45:24 | ERROR |
odoo.tests.result: 1 failed, 0 error(s) of 24 tests when loading database 'rb-bfce74a-221677-381264'
|
| 05/02/2026 01:45:24 | INFO |
Cleaning all resource
|
| 05/02/2026 01:45:24 | INFO |
Cleanup finished
|