Name:
[ADD/FIX] viin_ai: Phase 3.5 hardening + Phase 3.7 features (SRS v1.1 follow-up)
State:
Killed
finished in 234m
PR State:
merged
PR Author:
David Tran
PR Author Email:
PR:
#23
Committer:
David Tran
Committer Email:
davidtran.hp@gmail.com
Commit:
c686158ff25028317a83540fd50f43bb5ce971d3
Description:
[FIX] cluster ai17: align prettier trailingComma to es5 (CI default)
Runbot build 221688 build 381380 reported 261 prettier "Insert `,`"
errors after build 221687's fix added trailing commas via local
prettier --trailing-comma=all. Root cause: local eslint resolves
eslint-plugin-prettier@5.5.5 from /home/tuan/node_modules (bundled
prettier 3.x → default trailingComma=all), while the cluster-local
node_modules carries eslint-plugin-prettier@4.2.5 with prettier 2.8.8
whose default is trailingComma=es5. CI runbot uses the cluster-local
plugin chain (matches package.json), so trailing commas in function
calls/parameters trip "Insert `,`" with all but "Delete `,`" with es5.
Re-ran prettier 2.8.8 with no --trailing-comma override on all 149
ai17 static JS files; 76 files re-formatted (+261 −264 lines).
Verified locally with eslint --resolve-plugins-relative-to ai17
(forces v4.x resolution that matches CI) → 0 errors on full set.
Out of scope:
- Build 381388 MemoryError on web/tests/test_assets.py
test_logs_assets_generate_time during JS bundle minify is a runbot
infra flake (Odoo upstream test, not in 221687 on same branch); net
prettier delta of -3 lines cannot tip memory budget. Will retry on
next build.
Branch:
17.0
Instance ID:
0
Age:
Up-time: