Name:
[FIX] survey: keep the action helper alive when the RPC is unreachable
State:
Failed
finished in 153m
PR State:
open
PR Author:
Roy Le
PR Author Email:
PR:
#1315
Committer:
Roy Le
Committer Email:
roy.le@viindoo.com
Commit:
ea311d57a548e7cc63b5e507d1a4bd22f5937179
Description:
[FIX] account: compare the exchange lines of the payments widget unordered
_get_all_reconciled_invoice_partials unions its partial queries without an
ORDER BY and the payments widget lists the exchange lines in that order,
which depends on the plan PostgreSQL picks: with a merge join the rows come
sorted by the join key rather than by line id, and
test_reconcile_special_mexican_workflow_2 fails with
"{'line_ids': [4182, 4180, 4184], ...} != {'line_ids': [4180, 4182, 4184], ...}"
(reproducible locally with enable_hashjoin and enable_nestloop off). The order
of those ids only feeds the list view opened from the widget, so sort both
sides in the assertion helper.
Branch:
20.0
Age:
Up-time: