Skip to Content

Name: [FIX] website, test_website: merge upstream 19.0 and make website tours robust on slow runners

State: Failed finished in 220m

PR State: merged

PR Author: David Tran

PR Author Email:

PR: #1316

Committer: David Tran

Committer Email: david.tran@tvtmarine.com

Commit: 01d1866dad46358008ff0c7d19127e73f8b5c0d4

Description:

                                            [FIX] test_website: make test_replace_media tour robust on slow runners

After an image is replaced by another image, the step "ensure image
size is displayed" was satisfied by the old Image options container,
which stays mounted until the builder re-targets the new media. The
next "Replace" click then acted on the detached element ("Invalid
selection. Node is not part of the editable: None") and the Icon
container never appeared. Runbot signature: "[18/36] Tour
test_replace_media -> Step ensure icon block is displayed".

The tour now marks the container of the media being replaced and waits
for an Image container without that mark. That is the container of the
new media, a new component since containers are keyed per element.

Verified by injecting latency on /html_editor/get_image_info (+1 s):
the tour passes 3/3 with the fix and fails at the same step with the
same warning when the fix is reverted.

Signed-off-by: David Tran <david.tran@tvtmarine.com>
                                            

Branch: 19.0

Age:

Up-time: