Skip to Content

Name: [FIX] website_event: call the parent start with the widget as `this`

State: Killed finished in 384m

PR State: merged

PR Author: Roy Le

PR Author Email:

PR: #1313

Committer: Roy Le

Committer Email: roy.le@viindoo.com

Commit: 993a05d7db8058a2ee1ccb3b0dbf8ebc6d44d6c6

Description:

                                            [FIX] website_event: call the parent start with the widget as `this`

`this._super.apply(this.arguments)` passes `this.arguments` (undefined) as the
receiver and no arguments at all. The parent start therefore ran with an
undefined `this`, which has worked by accident only as long as the inherited
start never touched `this`: as soon as a module includes `publicWidget.Widget`
to wrap `start`, the registration form crashes with "Cannot read properties of
undefined (reading '_super')" and every website_event tour breaks.

Pass the widget and the real arguments, as `init` and `destroy` already do.
                                            

Branch: 17.0

Age:

Up-time: