PR State:
merged
PR:
#683
Commit:
d77754b6dad293bbe12c0d869ed4bd97a4c3098a
[FIX] viin_brand_website: wire the apps button off the DOM it is in
The apps-button spinner never ran on a real page. It was written as a
public Interaction, and the interaction service only ever scans from
#wrapwrap, but the button sits outside it - it is a
`body > .o_frontend_to_backend_nav > .o_frontend_to_backend_buttons >
a`, a #wrapwrap SIBLING, never a descendant. So the interaction never
started, the icon never swapped on click, and a Back-button restore
never reset it.
Replace it with a delegated click/auxclick listener bound on the
document at load time, which does not care where the button lives.
The three functions that decide what happens on click are unchanged.
The nine unit tests over the old Interaction had all been passing for
the wrong reason: the Hoot fixture helper wraps bare markup in a
#wrapwrap of its own, so the suite was exercising the button in a
position it never occupies on the real page. Those tests now mount
the fixture directly against the new listener, and a tour drives the
real rendered homepage - asserting both that the click swaps the icon
and that the button is NOT inside #wrapwrap, so a future core move
that reintroduces the mismatch fails loudly instead of passing for
the wrong reason again.
Branch:
19.0