Name:
[FIX] website_sale: a garbage ?category= on a product page must not answer 500
State:
Killed
finished in 224m
PR State:
merged
PR Author:
Roy Le
PR Author Email:
PR:
#1284
Committer:
Roy Le
Committer Email:
roy.le@viindoo.com
Commit:
df437fa247ae9b42a713f474de5808a87d052eed
Description:
[FIX] website_sale: a garbage ?category= on a product page must not
answer 500
SQL-injection scanners request product pages with payloads in ?category=
(e.g. "1' AND 1=1 UNION SELECT NULL-- -"): int(category) raised
ValueError in _prepare_product_values and the page answered 500 - 1,031
times in one week on a production 16.0 shop. The earlier guard only
covered the shop listing. The category only drives the breadcrumb and
the
back link here, so an invalid one is ignored, as upstream 19.0 does.
Branch:
16.0
Age:
Up-time: