Name:
[FIX] website_sale: a garbage ?category= on a product page must not answer 500
State:
Failed
finished in 179m
PR State:
merged
PR Author:
Roy Le
PR Author Email:
PR:
#1286
Committer:
Roy Le
Committer Email:
roy.le@viindoo.com
Commit:
3169c099e6bdc28711a202a09426f809508cd34b
Description:
[FIX] website_sale: a garbage ?category= on a product page must not answer 500
SQL-injection scanners request product pages with payloads in ?category=
(e.g. "1' AND 1=1 UNION SELECT NULL-- -"): int(category) raised
ValueError in _prepare_product_values and the page answered 500 - 1,031
times in one week on a production 16.0 shop. The earlier guard only
covered the shop listing. The category only drives the breadcrumb and the
back link here, so an invalid one is ignored, as upstream 19.0 does.
Branch:
17.0
Age:
Up-time: