PR State:
merged
PR:
#675
Commit:
8df11edcfd3191a244e2c64f45778cbd1f6307ec
[FIX] web_responsive: stop leaking a patch layer per command-palette keystroke
A prior fix on this branch (05b40f6) made the command-palette search variant
dismiss the apps-menu overlay only when a menu was actually selected, using a
temporary patch() on the menu service to detect the selection. That patch was
re-applied on every keystroke, but core's command service silently drops the
onClose callback on every call after the first while its palette stays open -
so only the first keystroke's patch layer was ever unwound, and each keystroke
after that permanently leaked one more wrapper layer onto the menu service for
the rest of the browser session.
Track whether an open-palette session is already being watched and only patch
the menu service + register the dismiss callback once per session; later
keystrokes in the same session now only update the palette's search value.
Adds a Hoot test covering the character-by-character search-typing path (the
one the prior tests bypassed) and trims two test comments per the repo's
comment convention.
Signed-off-by: David Tran <david.tran@tvtmarine.com>
Branch:
18.0