Name:
[FIX] viin_brand_common, web_responsive, viin_brand_mail, to_backend_theme: keep brand CSS out of core test bundles
State:
Failed
finished in 157m
PR State:
merged
PR Author:
David Tran
PR Author Email:
PR:
#673
Committer:
David Tran
Committer Email:
david.tran@tvtmarine.com
Commit:
fb7185e715c2086db887679ad2aa985d8c4df13b
Description:
[FIX] viin_brand_common: guard overrides out of public bundles
Lock in the separation the previous commit established, so it
cannot quietly rot. This module's overrides of core files belong to
the backend webclient and must stay out of the point-of-sale
terminal, the public mail page, the embedded livechat widget and the
attendance kiosk.
The guard asserts that in both directions: it also asserts the
emoji-picker override is still deliberately shared with the public
mail page and the livechat embed, so a future cleanup that mistakes
those two intentional declarations for part of the leak gets caught
instead of silently stripping brand coverage. It further asserts
every override still reaches the webclient, so nobody can turn the
suite green by deleting the overrides outright.
Verified: 22 tests pass on a live database, and the four
brand-appearance tours each still complete all three steps.
Signed-off-by: David Tran <david.tran@tvtmarine.com>
Branch:
18.0
Age:
Up-time: