Name:
[FIX] website: deflake edit_menus tour when menu items overflow the dialog
State:
Killed
finished in 193m
PR State:
merged
PR Author:
Roy Le
PR Author Email:
PR:
#1253
Committer:
Roy Le
Committer Email:
roy.le@viindoo.com
Commit:
3df6733404d515e49d724e4941099378611bdb89
Description:
[FIX] website: deflake edit_menus tour when menu items overflow the dialog
The final drag section of the edit_menus tour operates on rows the tour
itself appends at the bottom of the menu editor list. The drag helper
(drag_and_drop_native) computes viewport coordinates from
getBoundingClientRect() without scrolling the target into view first, so
when installed modules add enough top-level menu items (e.g. to_runbot
adds 'Runbot' and 'Runbot Standalone'), the rows to drag overflow the
fixed-height dialog body (~490px at 1366x768) and the pointer events
silently miss, failing the tour at:
Check if 'nested_menu' and 'Modnar !!' is nested under 'new_menu'
Scroll the dialog body to the bottom right before the drag section so
the dragged rows are always within view. Reproduced and verified on a
database where the tour-time list reaches 14-18 rows: failed 6/6 before,
passes 3/3 (14 rows), and still passes at 18 and 10 rows after the fix.
Branch:
17.0
Age:
Up-time: