Name: [IMP] viin_ai: ground answers on attached Sources, or refuse - and enforce the Assistant/Skill boundary

State: Succeed finished in 273m

PR State: merged

PR Author: David Tran

PR Author Email:

PR: #101

Committer: David Tran

Committer Email: davidtran.hp@gmail.com

Commit: dafe4fd4ec66b39b99c752db041f57d221c35b97

Description:

                                            [FIX] test_viin_ai: drive the end-to-end Sources runs as a real user

A sibling fix (845d5355) made viin_ai_agent refuse to retrieve Sources
under a superuser environment: the record-rule filter behind indexed
passages is bypassed there, so a routine-driven assistant could
otherwise read documents nobody may read. That guard is correct, but
this module's two full-stack Sources-grounding tests drove
agent.run() straight off the bare TransactionCase superuser env, so
both started failing for the wrong reason - hitting the new guard
instead of the behaviour they were written to prove.

Each fixture now creates a plain internal user (base.group_user only,
scoped to the test company) and drives every run through
agent.with_user(that_user).run(...) instead of the superuser call -
the same adaptation the sibling fix already applied to its own
grounding suite. This is also the more honest fixture: every real
surface (chat, livechat, controllers) drives an assistant as a real
user, never as root. Neither test's assertions changed - only the
actor did, so both still prove exactly what they were written to
prove: a retrieved passage reaching the model for a grounded answer,
and a chat-only-key configuration refusing with zero chat egress.

The module's other full-stack fixtures were swept for the same
pattern; none needed the same repair because none attach a source to
an agent before calling run(), so the guard's no-sources fast path
returns before it is ever reached.

Verified on a fresh install of an ephemeral 17.0 instance: 0 failed,
0 errors of 42 tests, with no warnings tied to this change.

Signed-off-by: David Tran <davidtran.hp@gmail.com>
                                            

Branch: 17.0

Instance ID: 0

Age:

Up-time:

Delete Date: