PR State:
merged
PR:
#43
Commit:
b93db89cd0686a40c3ed8983ac41193ec27ab1e1
[FIX] viin_web_editor,viin_brain,viin_ai_editor,viin_ai_brain: Runbot test_lint/test_pylint green
Reproduced the Runbot failures locally against Odoo 17 test_lint (period-correct
pylint 3.3.7) instead of guessing, and fixed the real root causes:
- test_pylint (Python): viin_brain/models/viin_brain_page_tag.py carried
'# pylint: disable=consider-merging-classes-inherited'. That message belongs
to the pylint-odoo plugin, which Odoo core test_pylint does NOT load, so the
inline disable resolves to unknown-option-value (W0012) - not suppressed by
'--disable=all,useless-option-value' - making pylint exit non-zero. The
message is not even in test_pylint's enable list, so the disable was inert.
Removed it. Verified pylint exit 0 across all 21 viin modules.
- test_eslint (JS): 417 prettier/prettier errors across P16 JS under the repo
.eslintrc.json (extends plugin:prettier/recommended, tabWidth 4, printWidth
100). The husky hook only formats staged files, so P16 files committed
earlier were never formatted. Ran eslint --fix; verified 0 errors against
both the repo prettier config and Odoo core eslintrc.
- test_manifests: viin_ai_editor set 'auto_install': False, which equals the
default manifest value (assertNotEqual hard-fail). Removed the key.
No behavior change: JS edits are pure formatting; Python edits delete an inert
key and an inert lint pragma. package-lock.json kept at baseline.
Branch:
17.0