PR State:
merged
PR:
#27
Commit:
0ea55a1fa96f031c3e53740a65818cb03a2f7e2b
[FIX] viin_brain: P8 revert ShareDialog collab seam wiring (pre-existing Share crash)
P8 retroactive visual-evidence run captured ShareDialog crash on Share
button click (Odoo Client Error). Initial hypothesis: P7 added `<t
t-slot="collabSection"/>` caused regression. Root-cause analysis via
baseline test on `~/git/ai17` at branch 17.0 (no hardening changes)
showed identical crash hash on Share button click — **pre-existing
bug**, NOT introduced by P7.
Pre-existing crash blocks any in-place verification of the collab seam
wiring. Reverted the JS slots prop + XML t-slot:
- share_dialog.js: removed `slots: { type: Object, optional: true,
shape: { collabSection: ... } }` from static props.
- share_dialog.xml: removed `<t t-slot="collabSection"/>` and the
earlier guarded `<t t-if=...><t t-slot/></t>`. Replaced with a
`<!-- v2 inject point -->` comment marker as anchor for v2
xpath-inheritance.
Updated docs/brain/v2-extension-points.md (seam #4) to:
- Mark seam as DOC-ONLY in v1.
- Document v2 attach pattern requiring (a) fix pre-existing Share
crash first, (b) patch ShareDialog props to add slots, (c) xpath
inherit template to inject t-slot at the comment marker.
Other 5 P7 seams (presence palette, GraphPanel canvas mount, AIBlock
state registry, Property type registry, Decorator providers doc)
remain wired in v1 and verified via compiled-CSS evidence in P8
retroactive run (15x `0.15s ease` transitions, 68x `:focus-visible`
rules, 8x `--o-brain-presence-color-1..8` vars, etc.).
Phase: P8 convergence (visual-evidence retroactive)
Pipeline: 20260503-brain-ui-hardening-v1
Plan: ~/.claude/plans/parsed-spinning-peacock.md
Branch:
17.0